Fix for "no routes found" on transaction confirmation page #19789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (13)
|
J-Son89
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
all good by me, but for sure @briansztamfater's input here would be great 🙏
ibrkhalil
reviewed
Apr 24, 2024
| (> (controlled-input/numeric-value input-state) | ||
| (current-limit))))) | ||
| current-limit (if @crypto-currency? crypto-limit fiat-limit) | ||
| valid-input? (not (or (empty? (controlled-input/input-value input-state)) |
There was a problem hiding this comment.
empty? Won't detect whitespace
Better to use clojure.string/blank?
vkjr
commented
Apr 24, 2024
| (<= (controlled-input/numeric-value input-state) 0) | ||
| (> (controlled-input/numeric-value input-state) | ||
| (current-limit))))) | ||
| current-limit (if @crypto-currency? crypto-limit fiat-limit) |
There was a problem hiding this comment.
Current limit is no longer a function because it don't need to be
| [input-value routes-can-be-fetched?]) | ||
| #(when (and active-screen? (> (count affordable-networks) 0)) | ||
| (fetch-routes input-value valid-input? 2000)) | ||
| [input-value valid-input?]) |
There was a problem hiding this comment.
Do we actually need to react to valid-input?? I think passing only input-value would be okay.
There was a problem hiding this comment.
Well, theoretically we can remove it because we know that input validity depends only on input value. But that is kind of knowledge that we have outside of the component. If for some reason the validity rule will change, not having valid-input? as a dependency can cause an error
vkjr
commented
Apr 24, 2024
| @@ -202,18 +202,20 @@ | |||
| :on-press-to-network on-press-to-network}])) | |||
|
|
|||
| (defn fetch-routes | |||
| [amount routes-can-be-fetched? bounce-duration-ms] | |||
| (if routes-can-be-fetched? | |||
| [amount valid-input? bounce-duration-ms] | |||
There was a problem hiding this comment.
This function was the cause of the problem. It was getting too generic condition routes-can-be-fetched? that was made from two logical conditions - if the valid is input and if we are still on the routes screen.
And when user navigated to confirmation page that condition became false which lead to clearing suggested routes.
Now in this function we rely only on input validity. And when the screen is wrong we dont't even call it.
vkjr
commented
Apr 24, 2024
| (set-input-state #(controlled-input/set-upper-limit % (current-limit)))) | ||
| [@crypto-currency?]) | ||
| (set-input-state #(controlled-input/set-upper-limit % current-limit))) | ||
| [current-limit]) |
There was a problem hiding this comment.
Now limit updated correctly.
ibrkhalil
approved these changes
Apr 24, 2024
vkjr
force-pushed
the
fix-no-routes-found
branch
from
d5432d9 to
af4ebcd
Compare
92% of end-end tests have passedFailed tests (2)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (48)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
OmarBasem
approved these changes
Apr 25, 2024
|
@pavloburykh, I believe that @mmilad75 fixed other causes of similar issue, no interference here. Plus I believe that PR should be rebased to take into account latest refactoring. @mmilad75, could you please take a look? |
|
Hi @vkjr, thank you for the fixes. The route fetching on the confirm page is now working correctly. The red highlight issue has also been resolved and not reproduced on real devices. However, it is still shown in Android Studio. Is this an Android Studio limitation and such issue is related only to Android Studio, or could the issue still exist on some devices?
Devices:Android Studio Pixel XL API 33 |
PR_ISSUE 1: The part of a tab is shown on 'send to' pageSteps:
Actual result:
Expected result:last nighly OS:IOS, Android Devices:
|
|
@VolodLytvynenko, don't know regarding Android Studio, let me check the code to get some guesses) |
vkjr
force-pushed
the
fix-no-routes-found
branch
from
af4ebcd to
c018aed
Compare
92% of end-end tests have passedFailed tests (2)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (48)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
|
vkjr
force-pushed
the
fix-no-routes-found
branch
from
c018aed to
23a86d5
Compare
|
@VolodLytvynenko , thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19780
Summary
This pr fixes:
Screen.Recording.2024-04-24.at.18.18.39.mov
Steps to test
status: ready